{"id":17009,"date":"2020-12-09T16:50:37","date_gmt":"2020-12-09T15:50:37","guid":{"rendered":"https:\/\/www.modelical.com\/es\/?p=17009"},"modified":"2022-03-30T14:22:33","modified_gmt":"2022-03-30T12:22:33","slug":"edit-ceilings-with-revit-api","status":"publish","type":"post","link":"https:\/\/www.modelical.com\/en\/edit-ceilings-with-revit-api\/","title":{"rendered":"Editing ceiling sketch with Revit API"},"content":{"rendered":"

We show you how to do it using programming<\/h2>\n

In many projects we will have to model the finishes, which can be a laborious task depending on the complexity of the project.<\/p>\n

Revit’s interface doesn’t have any tool that allows us to generate finishes automatically using the information of the rooms, however by programming we can easily make solutions to generate walls and floors, as we show with the node of the Modelical Dynamo Package Wall Finishes by room.<\/a>.<\/p>\n

The problem is when we reach the ceilings, after reviewing the API documentation<\/a> and looking for solutions on the web, we find ourselves with the following starting situation:<\/p>\n

  • Ceiling creation is not possible via Revit API.<\/li>\n
  • Ceiling editing is \u201cnot possible\u201d via Revit API.<\/li>\n

    With this post we will teach the reader how to modify the perimeter of the ceilings, exploiting the perimeter of a room. We will use a small example as a basis for this exercise:<\/p>\n

    \nLet’s suppose that, after creating manually all the ceilings of our model, in the last project update there was a mismatch due to a change in the architecture.<\/em><\/p>\n

    Having thousands of ceilings, updating the profiles would be a tedious task, fortunately this task is also potentially automatable. We will start with one ceiling and its room.<\/em>\n<\/p>\n

    \"\"<\/p>\n

    Getting the perimeter of the room<\/h3>\n

    The first thing we do is to get the room’s boundaries. To do this we can use the GetBoundarySegments<\/a> method from the SpatialElement<\/a> class.<\/p>\n

    This method returns a sublist of segment lists, being the first sublist the outer perimeter of the room and the following ones the inner loops.<\/p>\n

    Document currentDocument = ActiveUIDocument.Document;\r\n\r\nElementId roomId = new ElementId(207717);\r\n\r\nElement room = currentDocument.GetElement(roomId);\r\n\r\n\/\/get room boundary\r\nSpatialElementBoundaryOptions options = \r\n    new SpatialElementBoundaryOptions();\r\n\r\noptions.SpatialElementBoundaryLocation = \r\n    SpatialElementBoundaryLocation.Finish;\r\n            \r\nIList<Ilist<BoundarySegment>> roomBoundary = \r\n    (room as SpatialElement).GetBoundarySegments(options);<\/pre>\n
    We can see that in this example the room has been located using its id (we will do the same with the ceiling), this is because in this exercise we do not intend to identify which ceiling corresponds to which room, we leave that to the reader.<\/p>\n
    Getting the sketch of the ceiling<\/h3>\n
    Now we must get the sketch of the ceiling that we want to edit. In the Revit API we can achieve this in the following way:<\/p>\n
    ElementId ceilingId = new ElementId(210549);\r\n                \r\nElement ceiling = currentDocument.GetElement(ceilingId);\r\n            \r\n\/\/get ceiling sketch\r\nElementClassFilter filter = \r\n    new ElementClassFilter(typeof(Sketch));\r\n            \r\nElementId sketchId = \r\n    ceiling.GetDependentElements(filter).First();\r\n            \r\nSketch ceilingSketch = \r\n    currentDocument.GetElement(sketchId) as Sketch;\r\n            \r\nCurveArrArray ceilingProfile = ceilingSketch.Profile;\r\n<\/pre>\n
    This instance of the CurveArrArray<\/a> class is an array that contains subarrays that store the ceiling sketch lines, separated by loops, equivalent to the result obtained previously for the room.<\/p>\n
    The problem is that the elements of this instance cannot be modified, Revit will launch an exception of the type \u201cInvalidOperationException [\u2026] Collection is read-only\u201d if we try it.<\/em><\/p>\n
    Getting the editable lines<\/h3>\n
    While the Revit API does not allow us to directly modify the sketch, there is one thing we can do, get the lines that form the ceiling and modify them.<\/p>\n
    filter = new ElementClassFilter(typeof(CurveElement));\r\n                \r\nIEnumerable curves = ceiling.GetDependentElements(filter)\r\n    .Select(id => currentDocument.GetElement(id));\r\n                \r\nIEnumerable modelLines = curves\r\n    .Where(e => e is ModelLine).Cast();\/\/target\r\n                \r\nif(curves.Count() != modelLines.Count())\r\n     throw new Exception(\"The ceiling contains\" +\r\n\t                     \" non straight lines\");\r\n<\/pre>\n
    \nIn this case we have obtained a list of the lines that form the ceiling, without the loop structure.<\/p>\n
    The question would be how to change the lines that make up the ceiling and not break it in the attempt. To do this we have to take into account two particular conditions:<\/p>\n
  • We can change one line for another and we can remove lines, but we cannot add lines.<\/li>\n
  • We can edit the internal loops and we can eliminate them, except when such changes would conflict with the first condition. We cannot add new loops either.<\/li>\n
    This means that if the original ceiling had 7 edges on its outer perimeter, the new perimeter should have 7 or fewer edges. Also, the new ceiling may have the same or less number of inner loops and these inner loops may have the same or less edges than the original ones.<\/p>\n
    In this example there is another limitation that can be solved by the user: the ceiling and the room must be formed by straight lines.<\/b><\/p>\n
    At this point we can conclude that it may be interesting to preserve the structure of the ceiling sketch that we had achieved in the previous section, but using the model lines we have stored in the previous point. To do this we can do the following code:<\/p>\n
    IList<IList<ModelLine>> editableSketch = \r\n    new List<IList<ModelLine>>();\r\n            \r\nforeach (CurveArray loop in ceilingProfile) {\r\n     List<ModelLine> newLoop = new List<ModelLine>();\r\n\r\nforeach (Curve edge in loop) {\r\n                    \r\n          foreach (ModelLine modelLine in modelLines) {\r\n               \r\n               Curve currentLine = ((modelLine as ModelLine)\r\n                 .Location as LocationCurve).Curve;\r\n                        \r\n               if (currentLine.Intersect(edge) \r\n                    == SetComparisonResult.Equal){\r\n                    \r\n                    newLoop.Add(modelLine);\r\n                    break;\r\n               }\r\n                \r\n                editableSketch.Add(newLoop);\r\n          }\r\n     }\r\n}\r\n<\/pre>\n
    This code is running through all the lines of all the loops of the ceiling sketch (variable ceilingProfile) and looking for the same line in our list of model lines (variable modelLine). When the code finds the line, stores it in a new structure (variable editableSketch) that follows the structure of the sketch, but storing the editable lines.<\/p>\n
    Preventing errors<\/h3>\n
    To avoid exceptions the code should check that the conditions mentioned in the previous section are satisfied, before editing the ceiling.<\/p>\n
    The following code is a simplification that:<\/p>\n
  • Sorts the room and ceiling boundaries, leaving the outer perimeter as the first element, and ordering the rest of the loops from more to less number of edges.<\/li>\n
  • Checks the number of loops and the number of edges of room and ceiling.<\/li>\n
    \/\/sort room boundary\r\nIList<BoundarySegment> roomPerimeter = roomBoundary[0];\r\n            \r\nroomBoundary = roomBoundary.Skip(1)\r\n   .OrderByDescending(s => s.Count()).ToList();\r\n            \r\nroomBoundary.Insert(0, roomPerimeter);\r\n\r\n\/\/sort ceiling boundary            \r\nIList<ModelLine> ceilingPerimeter = editableSketch[0];\r\n            \r\neditableSketch = editableSketch.Skip(1)\r\n   .OrderByDescending(s => s.Count()).ToList();\r\n\r\neditableSketch.Insert(0, ceilingPerimeter);\r\n\r\n\/\/compare the number of loops and edges\r\nif(roomBoundary.Count() > editableSketch.Count()\r\n  || Enumerable.Range(0, Math.Min(roomBoundary.Count(),\r\n                                  editableSketch.Count()))\r\n  .Any(i => roomBoundary[].Count()>editableSketch[].Count()))\r\n{\r\n     throw new Exception(\r\n        \"The ceiling's sketch cannot be \"\r\n\t\t+ \"adapted to the room's shape.\");\r\n}\r\n<\/pre>\n
    Editing the ceiling<\/h3>\n
    We already have the original sketch of the ceiling and the shape of the room, which is what we want to obtain.
    \nNow we modify the ceiling lines to match those of the room, using the ModelLine<\/a> class as seen in the following code:<\/p>\n
    using (Transaction t = new Transaction(currentDocument, \r\n                                      \"Edit ceiling sketch\"))\r\n{\r\n   t.Start();\r\n                    \r\n   for(int i = 0; i < editableSketch.Count(); i++)\r\n   {\r\n      IList<ModelLine> ceilingLoop = editableSketch[];\r\n                        \r\n      if(i < roomBoundary.Count())\r\n      {\r\n         \/\/edit the current loop\r\n         IList<BoundarySegment> roomLoop = roomBoundary[];\r\n                            \r\n         for(int j = 0; j < ceilingLoop.Count(); j++)\r\n         {\r\n            ModelLine currentEdge = ceilingLoop[];\r\n                                \r\n            if(j < roomLoop.Count())\r\n            {\r\n               \/\/edit the current edge\r\n               BoundarySegment roomEdge = roomLoop[];\r\n                                    \r\n               Curve newEdge = roomEdge.GetCurve().Clone();\r\n                                    \r\n               if(!(newEdge is Line))\r\n                  throw new Exception(\r\n                     \"The room contains non straight lines\");\r\n\r\n               (currentEdge.Location as LocationCurve).Curve =\r\n\t\t\t       newEdge;\r\n            }\r\n            else\r\n            {\r\n               \/\/remove the current edge\r\n               currentDocument.Delete(currentEdge.Id);\r\n            }\r\n         }\r\n      }\r\n      else\r\n      {\r\n         \/\/remove the current loop\r\n         foreach(ModelLine line in ceilingLoop)\r\n         {\r\n         currentDocument.Delete(line.Id);\r\n         }\r\n      }\r\n   }\r\n\r\n   t.Commit();\r\n}\r\n<\/pre>\n
    It is important to insist on the use of the Clone<\/a> method of the Curve<\/a> class, used to replicate the line of the room. If it were not cloned, the line that defines the perimeter of the room would be internally linked to the line that delimits the ceiling, leading to errors when the user makes modifications to these elements from the Revit interface.<\/p>\n
    As some readers will have already noticed, this code allows us to modify the sketch of more elements than the ceilings, however other categories do have their own methods to create and modify their geometry, we recommend consulting Revit API documentation<\/a> to avoid falling into solutions that are more complex than necessary.<\/b><\/p>\n
    Conclusion<\/h3>\n
  • The Revit API doesn’t allow us to edit the ceiling sketch directly, but there are tricks to achieving this.<\/li>\n
    It may seem that this example has too many limitations, however it is the basis on which we were able to develop in Modelical<\/a> an add-in like the one below:<\/p>\n